Merged
Conversation
clauswilke
reviewed
Nov 16, 2021
Member
Author
|
I've decided to refactor |
clauswilke
reviewed
Nov 24, 2021
Member
clauswilke
left a comment
clauswilke
left a comment
There was a problem hiding this comment.
I think this is a good idea. Give me a few days to look this over carefully. On quick glance looks good though.
clauswilke
approved these changes
Nov 25, 2021
|
Not sure what is happening here, but these examples do not run correctly. https://ggplot2.tidyverse.org/reference/geom_hex.html
Warning message: |
Member
|
@jeffcraggy |
|
I see. Thought it came with the tidyverse ggplot2 object. Anyways I used the contour heat map . But thank you, he bin is a great feature
Jeff
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Hiroaki Yutani ***@***.***>
Sent: Saturday, February 19, 2022 9:42:34 PM
To: tidyverse/ggplot2 ***@***.***>
Cc: Jeff Craggy ***@***.***>; Mention ***@***.***>
Subject: Re: [tidyverse/ggplot2] Pass on binwidth and height to geom (PR #4671)
@jeffcraggy<https://github.com/jeffcraggy>
Hi, thanks for the report. You need to install hexbin package. I filed a new issue: #4736<#4736>
—
Reply to this email directly, view it on GitHub<#4671 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AXFMCCJQCQGK2J4C3HHP2STU4BIJVANCNFSM5IEKA6ZQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
schloerke
added a commit
to schloerke/ggplot2
that referenced
this pull request
Mar 23, 2022
* master: (320 commits) Orientation-aware key glyphs (tidyverse#4757) Fix warning in geom_violin with draw_quantiles (tidyverse#4654) Fix misalignment in geom_dotplot when stackratio != 1 and stackdir != "up" (tidyverse#4734) Replace coord_equal in scale-identity.r (tidyverse#4759) Unified message format in `geom_smooth()` (tidyverse#4634) Add parentheses to mentions of binned_scale in scale-alpha and scale-viridis documentation (tidyverse#4735) Update geom-boxplot.r (tidyverse#4744) Remove unneeded backslash from diamonds docs (tidyverse#4711) Re-document Warn on unsupported geoms in annotate() (tidyverse#4721) Re-document Add Trump to presidential terms dataset (tidyverse#4702) Corrects bins / binwidth override documentation (tidyverse#4720) Update infrastructure to new best practices (tidyverse#4748) remove stringsAsFactor for the mapped_discrete as.data.frame method (tidyverse#4750) Workflow updates (tidyverse#4747) Ensure output is numeric even if ifelse clause is NA (tidyverse#4692) Add non_missing_aes to geom_tile (tidyverse#4683) Pass on binwidth and height to geom (tidyverse#4671) Check for range == NULL - happens if no data has been added to plot (tidyverse#4682) ...
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4580
This PR makes
stat_bin_hex()writewidthandheightto the data whichgeom_hex()can pick up instead of deriving the resolution from data. This fixes issues with very sparse data where the bin resolution is not obvious from the bin centers